Enable COMPlus_JitDisasmWithGC with SuperPMI asm diffs#46966
Merged
BruceForstall merged 1 commit intodotnet:masterfrom Jan 25, 2021
Merged
Enable COMPlus_JitDisasmWithGC with SuperPMI asm diffs#46966BruceForstall merged 1 commit intodotnet:masterfrom
BruceForstall merged 1 commit intodotnet:masterfrom
Conversation
All SPMI asm diffs (generated using superpmi.py) will display interleaved GC info. Note that you can also pass the `--gcinfo` option to get traditional end-of-code asm dump, but that also requires adding per-instruction offset output, which can lead to excessive textual diffs.
Contributor
Author
|
This is an alternative to #45991, which just enabled it all the time. |
Contributor
Author
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
Jan 23, 2021
Member
AndyAyersMS
left a comment
There was a problem hiding this comment.
Yes, lLet's enable this and see how it works out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All SPMI asm diffs (generated using superpmi.py) will
display interleaved GC info.
Note that you can also pass the
--gcinfooptionto get traditional end-of-code asm dump, but that also
requires adding per-instruction offset output, which can lead
to excessive textual diffs.