Skip to content

Add Activity.SetBaggage API#46836

Merged
tarekgh merged 2 commits intodotnet:masterfrom
tarekgh:ActivitySetBaggage
Jan 14, 2021
Merged

Add Activity.SetBaggage API#46836
tarekgh merged 2 commits intodotnet:masterfrom
tarekgh:ActivitySetBaggage

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 11, 2021

Fixes #42706

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jan 11, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #42706

Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Tracing, new-api-needs-documentation

Milestone: -

@tarekgh
Copy link
Member Author

tarekgh commented Jan 11, 2021

@noahfalk could you please have a look? Thanks!

@tarekgh tarekgh requested a review from noahfalk January 11, 2021 23:15
@tarekgh tarekgh added this to the 6.0.0 milestone Jan 11, 2021
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh tarekgh merged commit 5495353 into dotnet:master Jan 14, 2021
@tarekgh tarekgh deleted the ActivitySetBaggage branch January 14, 2021 17:51
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to update Activity.Baggage

4 participants