Disable Speech Tests on Mono.#46828
Merged
lateralusX merged 1 commit intodotnet:masterfrom Jan 11, 2021
Merged
Conversation
Mono on netcore doesn't support COM wrappers that System.Speech depends on. Disable System.Speech.Tests on Mono.
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
safern
approved these changes
Jan 11, 2021
stephentoub
approved these changes
Jan 11, 2021
Member
Author
|
Windows x64 lane pass. runtime-staging (Build iOS x64 Release AllSubsets_Mono) timeout but not unique to this PR, can be found on several different PR's. |
danmoseley
approved these changes
Jan 11, 2021
Member
danmoseley
left a comment
There was a problem hiding this comment.
If those are the only ones affected, looks good to me. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mono on netcore doesn't support COM wrappers that System.Speech depends on. Disable System.Speech.Tests on Mono.