Fix PostEvictionCallbacks bug #46807
Merged
adamsitnik merged 4 commits intodotnet:masterfrom Jan 11, 2021
Merged
Conversation
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsExplanation: after #45962 the And it was causing a silent error after performing an invalid cast as a part of the scheduled task: runtime/src/libraries/Microsoft.Extensions.Caching.Memory/src/CacheEntry.cs Lines 207 to 209 in dfc70d1 Fixes #46774
|
stephentoub
reviewed
Jan 11, 2021
src/libraries/Microsoft.Extensions.Caching.Memory/tests/TokenExpirationTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2021
src/libraries/Microsoft.Extensions.Caching.Memory/tests/TokenExpirationTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 11, 2021
src/libraries/Microsoft.Extensions.Caching.Memory/tests/TokenExpirationTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 11, 2021
eerhardt
reviewed
Jan 11, 2021
src/libraries/Microsoft.Extensions.Caching.Memory/tests/TokenExpirationTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jan 11, 2021
src/libraries/Microsoft.Extensions.Caching.Memory/tests/TokenExpirationTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Jan 11, 2021
Member
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for getting the fix up so quick.
I just had a couple minor test suggestions.
- remove the dependency to TaskTimeoutExtensions - don't wait 1s, call Cancel in explicit way
pranavkm
approved these changes
Jan 11, 2021
Contributor
pranavkm
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: after #45962 the
thiskeyword was not referring to an instance of theCacheEntrytype:runtime/src/libraries/Microsoft.Extensions.Caching.Memory/src/CacheEntry.CacheEntryTokens.cs
Line 38 in 6b4c1ad
And it was causing a silent error after performing an invalid cast as a part of the scheduled task:
runtime/src/libraries/Microsoft.Extensions.Caching.Memory/src/CacheEntry.cs
Lines 207 to 209 in dfc70d1
Fixes #46774