Prefer ucontext.h over sys/ucontext.h#46790
Merged
janvorli merged 3 commits intodotnet:masterfrom Jan 14, 2021
am11:feature/illumos/ucontext-vs-sys_ucontext
Merged
Prefer ucontext.h over sys/ucontext.h#46790janvorli merged 3 commits intodotnet:masterfrom am11:feature/illumos/ucontext-vs-sys_ucontext
janvorli merged 3 commits intodotnet:masterfrom
am11:feature/illumos/ucontext-vs-sys_ucontext
Conversation
Member
Author
|
cc @janvorli |
janvorli
reviewed
Jan 11, 2021
am11
commented
Jan 12, 2021
janvorli
approved these changes
Jan 12, 2021
| if (CLR_CMAKE_HOST_OSX) | ||
| add_definitions(-D_XOPEN_SOURCE) | ||
| add_definitions(-DUNW_REMOTE_ONLY) | ||
| add_definitions(-D__APPLE__) |
Member
There was a problem hiding this comment.
Thank you for noticing this extra definition of __APPLE__
Member
Author
|
@janvorli, if there are no other feedback, could this be merged? |
Member
|
I am sorry for the delay, I haven't noticed that the CI was green. I should start setting auto-merge on PRs that I approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header
ucontext.hincludessys/ucontext.hon Linux, macOS and illumos with some additional defines and register handling. Vice-versa is true on FreeBSD.