Skip to content

Disable System.ComponentModel.Composition on Mono#46699

Merged
safern merged 1 commit intodotnet:masterfrom
lambdageek:followup-gh-43407-2
Jan 8, 2021
Merged

Disable System.ComponentModel.Composition on Mono#46699
safern merged 1 commit intodotnet:masterfrom
lambdageek:followup-gh-43407-2

Conversation

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Jan 7, 2021

Active issue is mono/mono#16417

There seems to be some kind of System.Reflection.Emit concurrency problem here

@lambdageek
Disable System.ComponentModel.Composition on Mono
23fd8a3 
Active issue is mono/mono#16417

There seems to be some kind of System.Reflection.Emit concurrency problem here
@ghost
Copy link

ghost commented Jan 7, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Active issue is mono/mono#16417

There seems to be some kind of System.Reflection.Emit concurrency problem here

Author: lambdageek
Assignees: -
Labels:

area-System.ComponentModel
Milestone: -

@lambdageek lambdageek added area-VM-reflection-mono Reflection issues specific to MonoVM disabled-test The test is disabled in source code against the issue and removed area-System.ComponentModel labels Jan 7, 2021
@ghost
Copy link

ghost commented Jan 7, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Active issue is mono/mono#16417

There seems to be some kind of System.Reflection.Emit concurrency problem here

Author: lambdageek
Assignees: -
Labels:

area-System.Reflection-mono, disabled-test
Milestone: -

@lambdageek lambdageek requested a review from steveisok January 7, 2021 20:18
@ghost
Copy link

ghost commented Jan 7, 2021

Hello @lambdageek!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@vcsjones vcsjones mentioned this pull request Jan 7, 2021
Merged
@am11
Copy link
Member

am11 commented Jan 7, 2021

what is stopping msftbot from merging this PR? (been all-green for past ~10 minutes) 🤔
(this is blocking clean CI in other PRs)

@safern safern merged commit 0798951 into dotnet:master Jan 8, 2021
@safern
Copy link
Member

safern commented Jan 8, 2021

@Anipik do you know why msftbot didn't merge?

This was referenced Jan 8, 2021
Closed
Open
@Anipik
Copy link
Contributor

Anipik commented Jan 12, 2021

@Anipik do you know why msftbot didn't merge?

i can take a look

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@safern safern safern approved these changes

Assignees

No one assigned

Labels

area-VM-reflection-mono Reflection issues specific to MonoVM disabled-test The test is disabled in source code against the issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lambdageek @am11 @safern @Anipik @steveisok @Dotnet-GitSync-Bot