Make const variables internal to be used by other classes#46693
Merged
jkotalik merged 3 commits intodotnet:masterfrom Jan 8, 2021
Merged
Make const variables internal to be used by other classes#46693jkotalik merged 3 commits intodotnet:masterfrom
jkotalik merged 3 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsWe used some of these const values in aspnetcore outside of the VariableLengthIntegerHelper, so making them internal (this syncs code with aspnetcore).
|
Member
|
Fixes: dotnet/aspnetcore#18943 |
Tratcher
approved these changes
Jan 7, 2021
JamesNK
approved these changes
Jan 7, 2021
...libraries/Common/src/System/Net/Http/aspnetcore/Http3/Helpers/VariableLengthIntegerHelper.cs
Show resolved
Hide resolved
JamesNK
reviewed
Jan 7, 2021
...libraries/Common/src/System/Net/Http/aspnetcore/Http3/Helpers/VariableLengthIntegerHelper.cs
Outdated
Show resolved
Hide resolved
…ers/VariableLengthIntegerHelper.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used some of these const values in aspnetcore outside of the VariableLengthIntegerHelper, so making them internal (this syncs code with aspnetcore).