Adding System.Math overloads for nint/nuint#46647
Merged
tannergooding merged 3 commits intodotnet:masterfrom Jan 8, 2021
Merged
Adding System.Math overloads for nint/nuint#46647tannergooding merged 3 commits intodotnet:masterfrom
tannergooding merged 3 commits intodotnet:masterfrom
Conversation
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @tannergooding, @pgovind Issue DetailsThis resolves #43733
|
stephentoub
approved these changes
Jan 6, 2021
Member
stephentoub
left a comment
There was a problem hiding this comment.
Other than the compiler error around the casting, LGTM. Seems like these are all mostly just copy/paste.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #43733