Reduce allocations in System.Threading.Channels for netstandard2.* and net461#46458
Merged
danmoseley merged 3 commits intodotnet:masterfrom Jan 22, 2021
Merged
Conversation
|
|
…d net461 System.Threading.Channels.AsyncOperation<TResult> is well optimized for .NET Core, but there are no optimizations for .NET Standard 2.0 and .NET Framework. They use the same code as .NET Standard 1.3.
d0372d8 to
8273de5
Compare
stephentoub
reviewed
Jan 4, 2021
...aries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.netstandard2.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 19, 2021
...aries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.netstandard2.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 19, 2021
...aries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.netstandard2.cs
Show resolved
Hide resolved
Contributor
Author
|
@stephentoub, you're welcome! |
Contributor
Author
|
Some checks were not successful. Why? Can I help with this? |
Member
|
I hit retry on those jobs. |
Member
|
Thanks for the contribution @KorneiDontsov . We welcome contributions, perhaps there is some other issue or contribution you're interested in in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System.Threading.Channels.AsyncOperation<TResult>is well optimized for .NET Core, but there are no optimizations for .NET Standard 2.0 and .NET Framework. They use the same code as .NET Standard 1.3.I used ThreadPool and ExecutionContext API, that are available in .NET Standard 2.* and .NET Framework, to reduce the amount of allocations.