Skip to content

always try to add the result of getegid to the list returned by getgroups #46302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 2 commits into from
Dec 24, 2020
Merged

always try to add the result of getegid to the list returned by getgroups #46302

adamsitnik merged 2 commits into from
Dec 24, 2020

Conversation

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Dec 21, 2020

https://man7.org/linux/man-pages/man2/getgroups.2.html

   It is unspecified whether the effective group ID of the calling
   process is included in the returned list.  (Thus, an application
   should also call getegid(2) and add or remove the resulting value.)

Another try to fix #28922

@adamsitnik
according to https://man7.org/linux/man-pages/man2/getgroups.2.html i…
360b674 
…t's not specified if this group is included in the list returned by getgroups
@ghost
Copy link

ghost commented Dec 21, 2020

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

https://man7.org/linux/man-pages/man2/getgroups.2.html

   It is unspecified whether the effective group ID of the calling
   process is included in the returned list.  (Thus, an application
   should also call getegid(2) and add or remove the resulting value.)

Another try to fix #28922

Author: adamsitnik
Assignees: -
Labels:

area-System.Diagnostics.Process
Milestone: -

@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 21, 2020

/azp run runtime-libraries-coreclr outerloop-linux

@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 21, 2020

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Dec 21, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik adamsitnik added disabled-test The test is disabled in source code against the issue test-bug Problem in test source code (most likely) labels Dec 21, 2020
@adamsitnik adamsitnik added this to the 6.0.0 milestone Dec 21, 2020
@adamsitnik adamsitnik marked this pull request as ready for review December 21, 2020 23:40
@adamsitnik adamsitnik requested a review from wfurt December 21, 2020 23:41
@adamsitnik adamsitnik mentioned this pull request Dec 21, 2020
Closed
@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 22, 2020

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 22, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 22, 2020

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 22, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 22, 2020

I've forgot to re-enable this test... apologies for that.

@adamsitnik
Copy link
Member Author

adamsitnik commented Dec 22, 2020

@wfurt it looks like it did the trick and the test has passed (the CI failures are not related to Process)

wfurt
wfurt approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adamsitnik adamsitnik merged commit 3ae36b5 into dotnet:master Dec 24, 2020
@adamsitnik adamsitnik deleted the getegid branch December 24, 2020 13:49
@jeffhandley jeffhandley mentioned this pull request Jan 13, 2021
Closed
6 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt wfurt approved these changes

Assignees

No one assigned

Labels

area-System.Diagnostics.Process disabled-test The test is disabled in source code against the issue test-bug Problem in test source code (most likely)

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Test failure: System.Diagnostics.Tests.ProcessTests/TestCheckChildProcessUserAndGroupIds

3 participants

@adamsitnik @wfurt @Dotnet-GitSync-Bot