Skip to content

Pinning package version for packages not being serviced#46224

Merged
Anipik merged 1 commit intodotnet:release/5.0from
Anipik:pin
Jan 14, 2021
Merged

Pinning package version for packages not being serviced#46224
Anipik merged 1 commit intodotnet:release/5.0from
Anipik:pin

Conversation

@Anipik
Copy link
Contributor

@Anipik Anipik commented Dec 18, 2020

This change fixes the problem of inconsistent package index. when we build with the stable flag on , the build system updates the package index to reflect the new package version as stable which is not true for packages not being serviced.

This is also required for sourcebuild which builds all the packages in servicing release as well

@ghost
Copy link

ghost commented Dec 18, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This change fixes the problem of inconsistent package index. when we build with the stable flag on , the build system updates the package index to reflect the new package version as stable which is not true.

This is also required for sourcebuild which builds all the packages in servicing release as well

Author: Anipik
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@Anipik
Copy link
Contributor Author

Anipik commented Jan 14, 2021

@safern @ViktorHofer @ericstj can u review this one ?

@Anipik Anipik merged commit 792ab31 into dotnet:release/5.0 Jan 14, 2021
@ericstj
Copy link
Member

ericstj commented Jan 14, 2021

Thank you for doing this @Anipik. I wasn't sure if this change would be sufficient: we should double check the packages produced in 5.0.3 and make sure we aren't clashing with an GA identities. If we are, we might need to opt those packages into the incremented version.

@Anipik
Copy link
Contributor Author

Anipik commented Jan 14, 2021

Thank you for doing this @Anipik. I wasn't sure if this change would be sufficient: we should double check the packages produced in 5.0.3 and make sure we aren't clashing with an GA identities. If we are, we might need to opt those packages into the incremented version.

what do u mean by GA identities ? are you referring to GA package version ?

@ericstj
Copy link
Member

ericstj commented Jan 14, 2021

Yeah, just to make sure we don't try to republish any of the exact same package versions that we built in the GA build. I'm not too concerned with Libraries, moreso the other random packages that build in coreclr and installer. Do any of those rely on being auto-incremented?

@Anipik
Copy link
Contributor Author

Anipik commented Jan 14, 2021

Yeah, just to make sure we don't try to republish any of the exact same package versions that we built in the GA build. I'm not too concerned with Libraries, moreso the other random packages that build in coreclr and installer. Do any of those rely on being auto-incremented?

i will do a complete build and verify that

@Anipik Anipik deleted the pin branch January 30, 2021 21:41
@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants