Windows build.cmd doesn't support -cmakeargs.#46195
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
fa1a5ea to
c5342cc
Compare
|
Tagging subscribers to this area: @ViktorHofer Issue Detailsbuild.sh supports -cmakeargs making it is possible to pass custom cmake arguments down to native cmake steps, but this feature is missing on Windows when using build.cmd. Trying to do: .\build.cmd -subset clr -c release -cmakeargs "-DFEATURE_PERFTRACING_C_LIB=1" on Windows will result in an error since -cmakeargs is not a known command in build.ps1. Commit adds support for -cmakeargs in build.cmd making sure it gets passed down to runtime build on both CoreClr as well as Mono.
|
496a8a2 to
d758d45
Compare
4aa5c70 to
5c1e041
Compare
build.sh supports -cmakeargs making it is possible to pass custom cmake arguments down to native cmake steps, but this feature is missing on Windows when using build.cmd. Trying to do: .\build.cmd -subset clr -c release -cmakeargs "-DFEATURE_PERFTRACING_C_LIB=1" on Windows will result in an error since -cmakeargs is not a known command in build.ps1. Commit adds support for -cmakeargs in build.cmd making sure it gets passed down to runtime build on both CoreClr as well as Mono.
5c1e041 to
8bbc1bc
Compare
|
Hello @akoeplinger! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
build.sh supports -cmakeargs making it is possible to pass custom cmake arguments down to native cmake steps, but this feature is missing on Windows when using build.cmd. Trying to do:
.\build.cmd -subset clr -c release -cmakeargs "-DFEATURE_PERFTRACING_C_LIB=1"
on Windows will result in an error since -cmakeargs is not a known command in build.ps1.
Commit adds support for -cmakeargs in build.cmd making sure it gets passed down to runtime build on both CoreClr as well as Mono.