Skip to content

remove workaround in #40310 #46154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lewing merged 1 commit into from
Dec 16, 2020
Merged

remove workaround in #40310 #46154

lewing merged 1 commit into from
Dec 16, 2020

Conversation

@lewing
Copy link
Member

@lewing lewing commented Dec 16, 2020

No description provided.

@lewing lewing added the arch-wasm WebAssembly architecture label Dec 16, 2020
@lewing lewing mentioned this pull request Dec 16, 2020
Merged
@steveisok steveisok self-requested a review December 16, 2020 22:33
@lewing
Copy link
Member Author

lewing commented Dec 16, 2020

Failure is unrelated runtime (Libraries Test Run release coreclr Linux x64 Debug)

    System.Diagnostics.Tests.ProcessWaitingTests.WaitAsyncForSignal [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs(476,0): at System.Diagnostics.Tests.ProcessWaitingTests.WaitAsyncForSignal()
        --- End of stack trace from previous location ---
  Finished:    System.Diagnostics.Process.Tests

@lewing lewing merged commit 8e913a2 into dotnet:master Dec 16, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing @steveisok @Dotnet-GitSync-Bot