Fix previously overlooked path to pgocheck.py (src/coreclr/src)#46019
Merged
trylek merged 2 commits intodotnet:masterfrom Dec 14, 2020
Merged
Fix previously overlooked path to pgocheck.py (src/coreclr/src)#46019trylek merged 2 commits intodotnet:masterfrom
trylek merged 2 commits intodotnet:masterfrom
Conversation
Looking around the script I also noticed that __SourceDir is not used anymore so I removed it. Thanks Tomas
Member
|
Since you’re already touching this, can you update the script to check the exit code and error out if the script fails? |
Member
Author
|
@jkoritzinsky - thanks for pointing that out, fixed in 2nd commit. |
Member
|
This PR now fixes #35089 |
jkoritzinsky
approved these changes
Dec 13, 2020
ViktorHofer
approved these changes
Dec 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking around the script I also noticed that __SourceDir
is not used anymore so I removed it.
Thanks
Tomas