Skip to content

Redirect default install location in test to avoid using machine-wide install#45500

Merged
elinor-fung merged 1 commit intodotnet:masterfrom
elinor-fung:fixMultipleHivesTest
Dec 2, 2020
Merged

Redirect default install location in test to avoid using machine-wide install#45500
elinor-fung merged 1 commit intodotnet:masterfrom
elinor-fung:fixMultipleHivesTest

Conversation

@elinor-fung
Copy link
Member

Test for framework resolution with multiple hives enables multi-level lookup. Explicitly set the default install path to an invalid location so that any actual machine-wide install won't be used in the test.

@ghost
Copy link

ghost commented Dec 2, 2020

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

Test for framework resolution with multiple hives enables multi-level lookup. Explicitly set the default install path to an invalid location so that any actual machine-wide install won't be used in the test.

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - how come we didn't hit this before :-(
Thanks for fixing this!

@elinor-fung elinor-fung merged commit a247e78 into dotnet:master Dec 2, 2020
@elinor-fung
Copy link
Member Author

I think it just happened that the version we used for testing were such that no real install would satisfy them - until 5.0 RTM came along.

@elinor-fung
Copy link
Member Author

Bah, I think we are going to want this ported to 5.0 - looks like CI machines are being updated to a newer VS such that they will now have .NET 5.0 installed and will hit this failure.

@elinor-fung
Copy link
Member Author

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/397483119

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants