Remove dependency on PerfCounter.dll#45142
Conversation
This dependency was unnecessary and only for calling through to pdh.dll. PerfCounter.dll is still needed for the consumption side of performance counters, but removing from the dependency from the .NET can help enable some scenarios like reading non-.NET counters.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @tommcdon, @krwq Issue DetailsThis dependency was unnecessary and only for calling through to pdh.dll. PerfCounter.dll is still needed for the consumption side of performance
|
|
Contributes to #41144 |
|
So running on ARM we now have: The tests which fail are failing due to inability to read .NET perf counters. This is due to absense of netfxperf.dll/perfcounter.dll. I'm going through and fixing all the test conditions to address this. |
d42a8f8 to
027161a
Compare
|
@Anipik @danmosemsft can you have a look at this one? It enables the reading of non-.NET perf counters on Windows ARM64. |
danmoseley
left a comment
There was a problem hiding this comment.
LGTM - I see FormatFromRawValue is just a pass through in perfcounter.dll
This dependency was unnecessary and only for calling through to pdh.dll.
PerfCounter.dll is still needed for the consumption side of performance
counters, but removing from the dependency from the .NET can help enable
some scenarios like reading non-.NET counters.