Skip to content

Add test for Timer.Elapsed DateTime#44881

Merged
stephentoub merged 1 commit intodotnet:masterfrom
stephentoub:timerdt
Nov 18, 2020
Merged

Add test for Timer.Elapsed DateTime#44881
stephentoub merged 1 commit intodotnet:masterfrom
stephentoub:timerdt

Conversation

@stephentoub
Copy link
Member

To help validate #44853

@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:

To help validate #44853

Author: stephentoub
Assignees: -
Labels:

area-System.ComponentModel

Milestone: -

@Clockwork-Muse
Copy link
Contributor

Assert.Equal(DateTimeKind.Local, e.SignalTime.Kind);

:glares frustratedly at the kind:

I assume it would be a breaking change to correct it to UTC.

Regardless of that, should the start/end times be captured in UTC? Although it won't completely solve issues with testing during DST.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub
Copy link
Member Author

Regardless of that, should the start/end times be captured in UTC?

I was capturing in Local and then using ToUniversal to keep things consistent with the data being captured from the API. I'm not sure it really matter either way.

@stephentoub stephentoub merged commit 722fb86 into dotnet:master Nov 18, 2020
@stephentoub stephentoub deleted the timerdt branch November 18, 2020 23:06
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants