Add test for Timer.Elapsed DateTime#44881
Merged
stephentoub merged 1 commit intodotnet:masterfrom Nov 18, 2020
Merged
Conversation
Contributor
Assert.Equal(DateTimeKind.Local, e.SignalTime.Kind);:glares frustratedly at the kind: I assume it would be a breaking change to correct it to UTC. Regardless of that, should the start/end times be captured in UTC? Although it won't completely solve issues with testing during DST. |
Member
Author
I was capturing in Local and then using ToUniversal to keep things consistent with the data being captured from the API. I'm not sure it really matter either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help validate #44853