Use read-only auto-implemented property#44677
Merged
stephentoub merged 2 commits intodotnet:masterfrom Nov 18, 2020
Merged
Conversation
Use read-only auto-implemented property (RCS1170) https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1170.md
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
|
Thanks for the PR, @xtqqczze. The plethora of compilation failures need to be resolved before we can look at this. |
Contributor
Author
|
CI failures due to #44700. |
Contributor
Author
|
reopening to restart tests |
Contributor
Author
|
reopening to restart tests |
Contributor
Author
|
restarting tests |
Contributor
Author
|
@stephentoub I've reverted changes to the bare minimum to avoid divergence from PowerShell/PowerShell#13507. |
Contributor
Author
|
Some day I will work out how to open the solution in Visual Studio and run a local build so I can make more substantial contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix style issue and avoid diverging from PowerShell repo.
In PowerShell/PowerShell#13507 changes like these were made to the following file which comes from dotnet/runtime:
https://github.com/xtqqczze/PowerShell/blob/b201ca0b8ed736155c1761e60dfd88f82a545c65/src/System.Management.Automation/engine/ComInterop/InteropServices/ComEventsMethod.cs
So I thought it would be helpful to make changes in dotnet/runtime too.