Run Mono iOS sample on Helix by MaximLipnin · Pull Request #44462 · dotnet/runtime

MaximLipnin · 2020-11-10T13:56:33Z

Included the ios sample project to the library test build. The sample still can be build/run locally using make file.
Added copying resulting HelloiOS.app to helix directory from where it can be consumed by CI.
Changed the sample to return 42 when building for CI, which is used as an expected exit code for xharness.
Xharness for iOS supports running an application on a simulator w/o test runner inside, the sample is run by this approach.
Checked locally that xharness can run HelloiOS.app successfully.

Related issue: #43865

Dotnet-GitSync-Bot · 2020-11-10T13:56:38Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

steveisok · 2020-11-11T01:58:10Z

Might have to rebase to get CI to play nice.

MaximLipnin · 2020-12-03T10:19:06Z

At the moment it requires arcade helix sdk bump to, at least, version=6.0.0-beta.20577.1".

MaximLipnin · 2020-12-04T09:28:09Z

According to the CI log, the sample runs as expected:

[03:47:11] dbug: 03:47:11.4844910 Xamarin.Hosting: Launched net.dot.HelloiOS with pid 84147
[03:47:28] dbug: 03:47:28.5087870 Xamarin.Hosting: Simulated process has exited.
[03:47:28] dbug: 03:47:28.5138190 Process mlaunch exited with 0
[03:47:28] dbug: 03:47:28.5184190 App run ended with 42
[03:47:28] info: Application has finished with exit code: 42 (as expected)
XHarness exit code: 0

src/mono/netcore/sample/iOS/Program.csproj

steveisok · 2020-12-04T21:53:26Z

@akoeplinger Please give this a review.

SamMonoRT

We should figure out why xharness return code is 42 and not 0 or 1 or 100. That seems strange to me. @fanyang-mono didn't you encounter something similar while bringing up the Android simulator runtime tests ?

steveisok · 2020-12-08T20:36:20Z

@SamMonoRT It's a made up return code. We should return 0 for correctness.

src/mono/netcore/sample/iOS/Program.cs

src/libraries/sendtohelixhelp.proj

akoeplinger

Good job, left a few comments. The biggest issue for me is the Publish->Build change.

src/libraries/tests.proj

src/mono/netcore/sample/iOS/Program.csproj

src/libraries/sendtohelixhelp.proj

src/mono/netcore/sample/iOS/Program.cs

MaximLipnin · 2020-12-10T15:16:35Z

Strange error on ios lane:

2020-12-10T14:31:44.3629640Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018: The "AppleAppBuilderTask" task failed unexpectedly. [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.3734380Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'chunkLength') [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.3736450Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at System.Text.StringBuilder.ToString() [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.3838790Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at Utils.RunProcess(String path, String args, IDictionary`2 envVars, String workingDir, Boolean ignoreErrors) in /_/src/tasks/AppleAppBuilder/Utils.cs:line 75 [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.3941870Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at Xcode..ctor(String target) in /_/src/tasks/AppleAppBuilder/Xcode.cs:line 18 [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.3958970Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at AppleAppBuilderTask.Execute() in /_/src/tasks/AppleAppBuilder/AppleAppBuilder.cs:line 175 [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.4021940Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]
2020-12-10T14:31:44.4052500Z /Users/runner/work/1/s/eng/testing/tests.mobile.targets(117,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/runner/work/1/s/src/libraries/System.Private.Xml.Linq/tests/events/System.Xml.Linq.Events.Tests.csproj]

MaximLipnin · 2020-12-10T17:09:10Z

The PR is completely green now.

…OS.app to helix test directory

… successful run of the sample app.

MaximLipnin · 2020-12-11T09:13:16Z

runtime-staging (Build iOS x64 Release AllSubsets_Mono) lane looks good.

https://dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/917369/logs/36
https://helix.dot.net/api/jobs/50a6e4a7-1764-4844-8b4f-b785ed0288b7/workitems/HelixController%20Work%20Queueing?api-version=2019-06-17
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-44462-merge-50a6e4a7176448448b/HelloiOS/console.c94a3ae8.log?sv=2019-07-07&se=2020-12-31T08%3A49%3A45Z&sr=c&sp=rl&sig=aHbWhRurp7%2BOFfFLs44HWct6fJqaKxsYkayu7Bms2b0%3D

MaximLipnin requested review from EgorBo, akoeplinger, mdh1418 and steveisok November 10, 2020 13:56

MaximLipnin mentioned this pull request Nov 10, 2020

[Mono] Turn Samples into Functional Tests #44016

Closed

MaximLipnin force-pushed the run_ios_sample_on_helix branch from 196be3e to 7584af3 Compare November 10, 2020 17:38

MaximLipnin force-pushed the run_ios_sample_on_helix branch 2 times, most recently from a436144 to 6c30fcb Compare November 16, 2020 06:49

MaximLipnin mentioned this pull request Nov 16, 2020

[iOS] Recognize the successful run of mono sample application dotnet/xharness#363

Closed

MaximLipnin force-pushed the run_ios_sample_on_helix branch 2 times, most recently from 33637b8 to 4e3fcd0 Compare November 27, 2020 11:32

runfoapp bot mentioned this pull request Nov 30, 2020

Inability to unzip assets during build on Unix x64 #32805

Closed

MaximLipnin force-pushed the run_ios_sample_on_helix branch from a47a2a6 to baddbfb Compare December 1, 2020 09:01

MaximLipnin force-pushed the run_ios_sample_on_helix branch from baddbfb to 40e64a0 Compare December 4, 2020 07:31

MaximLipnin marked this pull request as ready for review December 4, 2020 09:52

MaximLipnin requested review from marek-safar and vargaz as code owners December 4, 2020 09:52

steveisok reviewed Dec 4, 2020

View reviewed changes

src/mono/netcore/sample/iOS/Program.csproj Outdated Show resolved Hide resolved

steveisok approved these changes Dec 4, 2020

View reviewed changes

SamMonoRT reviewed Dec 8, 2020

View reviewed changes

naricc self-requested a review December 8, 2020 20:36

naricc reviewed Dec 8, 2020

View reviewed changes

src/mono/netcore/sample/iOS/Program.cs Outdated Show resolved Hide resolved

SamMonoRT reviewed Dec 8, 2020

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

naricc reviewed Dec 8, 2020

View reviewed changes

src/libraries/sendtohelixhelp.proj Outdated Show resolved Hide resolved

naricc approved these changes Dec 8, 2020

View reviewed changes

MaximLipnin force-pushed the run_ios_sample_on_helix branch from 5cbee5a to cb209e7 Compare December 9, 2020 08:39

radical mentioned this pull request Dec 9, 2020

failing test: System.Diagnostics.Tests.EventLogSessionTests.ClearLog_LogExists_Success #45847

Closed

akoeplinger requested changes Dec 9, 2020

View reviewed changes

MaximLipnin force-pushed the run_ios_sample_on_helix branch 2 times, most recently from 51aa8cb to 8bdf1dc Compare December 10, 2020 09:20

akoeplinger approved these changes Dec 10, 2020

View reviewed changes

MaximLipnin added 16 commits December 11, 2020 10:02

Include sample ios application to the library test build; copy Helloi…

3aab2ea

…OS.app to helix test directory

Update Main method to return 42 in order to help xharness recognize a…

3efdcb3

… successful run of the sample app.

Use xharness ios run to run sample app

b497f0b

Add expected exit code and exclude test runner

39feaf0

Use a separate work item for run-only app

138518c

Fix tags

5c042f7

Fix path

3046439

Use a separate helix directory for run-only apps

9cae92a

Remove the changes in the runner template

0707c31

Revert unnecessary changes in makefile

983f480

Address the feedback

c6d5310

Space

e7a32c4

Bring non-zero exit code back.

3a0d05e

Remove redundant project exclusion item

7ad7737

Return non-zero exit code only for CI testing

098aa87

Return to Publish

83e027e

MaximLipnin force-pushed the run_ios_sample_on_helix branch from ea67bb6 to 83e027e Compare December 11, 2020 07:03

MaximLipnin merged commit d7aca56 into dotnet:master Dec 11, 2020

MaximLipnin deleted the run_ios_sample_on_helix branch December 11, 2020 12:00

ghost locked as resolved and limited conversation to collaborators Jan 10, 2021

Conversation

MaximLipnin commented Nov 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dotnet-GitSync-Bot commented Nov 10, 2020

Uh oh!

steveisok commented Nov 11, 2020

Uh oh!

MaximLipnin commented Dec 3, 2020

Uh oh!

MaximLipnin commented Dec 4, 2020

Uh oh!

Uh oh!

steveisok commented Dec 4, 2020

Uh oh!

SamMonoRT left a comment

Choose a reason for hiding this comment

Uh oh!

steveisok commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akoeplinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaximLipnin commented Dec 10, 2020

Uh oh!

MaximLipnin commented Dec 10, 2020

Uh oh!

MaximLipnin commented Dec 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

MaximLipnin commented Nov 10, 2020 •

edited

Loading

steveisok commented Dec 8, 2020 •

edited

Loading