Skip to content

Use the new async Run method from xharness and implement a test#44046

Merged
lewing merged 3 commits intodotnet:masterfrom
lewing:wasm-async-runner
Nov 5, 2020
Merged

Use the new async Run method from xharness and implement a test#44046
lewing merged 3 commits intodotnet:masterfrom
lewing:wasm-async-runner

Conversation

@lewing
Copy link
Member

@lewing lewing commented Oct 30, 2020 •
edited
Loading

Update browser tests to use dotnet/xharness#345 and be able to run promise related tests. Depends on #44045

The build will fail until the xharness change makes it in.

@lewing lewing added arch-wasm WebAssembly architecture area-Interop-mono labels Oct 30, 2020
@lewing lewing requested review from akoeplinger and kjpou1 October 30, 2020 02:53
@lewing lewing mentioned this pull request Oct 30, 2020
Closed
@runfoapp runfoapp bot mentioned this pull request Oct 30, 2020
Closed
@lewing lewing force-pushed the wasm-async-runner branch from de1d413 to 1dd661d Compare October 30, 2020 20:26
@lewing
Copy link
Member Author

lewing commented Oct 30, 2020 •
edited
Loading

This currently includes #44045 for ease of testing, will clean it up once that lands

@akoeplinger can more of the timer queue be removed?

@monojenkins monojenkins mentioned this pull request Oct 30, 2020
Merged
@runfoapp runfoapp bot mentioned this pull request Oct 30, 2020
Open
@lewing lewing mentioned this pull request Oct 31, 2020
Merged
@lewing lewing force-pushed the wasm-async-runner branch from 1dd661d to e188f36 Compare November 5, 2020 18:01
@lewing lewing marked this pull request as ready for review November 5, 2020 18:01
@lewing
Copy link
Member Author

lewing commented Nov 5, 2020

coreclr windows test failures are #44332
the linux failures are timeouts. One in the Pipelines test at

/root/helix/work/correlation/dotnet exec --runtimeconfig System.IO.Pipelines.Tests.runtimeconfig.json --depsfile System.IO.Pipelines.Tests.deps.json xunit.console.dll System.IO.Pipelines.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem /root/helix/work/workitem
  Discovering: System.IO.Pipelines.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.IO.Pipelines.Tests (found 327 of 331 test cases)
  Starting:    System.IO.Pipelines.Tests (parallel test collections = on, max threads = 4)
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:02:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:04:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:06:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:08:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:10:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:12:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:14:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:16:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:18:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:20:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:22:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:24:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:26:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:28:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:30:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:32:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:34:46
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:36:47
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:38:47
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:40:47
   System.IO.Pipelines.Tests: [Long Running Test] 'System.IO.Pipelines.Tests.PipeReaderWriterStreamTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:42:47

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 2700 seconds and was killed

on coreclr arm https://dev.azure.com/dnceng/public/_build/results?buildId=876982&view=logs&j=2845845c-bfb0-5f35-d712-13f6aa4acce2&t=1eea787e-19ba-5879-da86-a8ad1dabcc65&l=58

And the mono one in System.Collections.Concurrent.Tests with almost no data

Executed on a0001V8
+ ./RunTests.sh --runtime-path /home/helixbot/work/A67B08BF/p
----- start Thu Nov 5 20:51:05 UTC 2020 =============== To repro directly: =====================================================
pushd .
/home/helixbot/work/A67B08BF/p/dotnet exec --runtimeconfig System.Collections.Concurrent.Tests.runtimeconfig.json --depsfile System.Collections.Concurrent.Tests.deps.json xunit.console.dll System.Collections.Concurrent.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
~/work/A67B08BF/w/AA730972/e ~/work/A67B08BF/w/AA730972/e
  Discovering: System.Collections.Concurrent.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Collections.Concurrent.Tests (found 871 of 880 test cases)
  Starting:    System.Collections.Concurrent.Tests (parallel test collections = on, max threads = 2)

@lewing
Copy link
Member Author

lewing commented Nov 5, 2020

Http Functional timed out on the latest run on coreclr windows x64

https://dev.azure.com/dnceng/public/_build/results?buildId=876982&view=logs&j=bf603221-817a-5f42-894a-9eb35c3c7f97&t=7b6c19b2-2655-5e8f-d26a-63d3381d63ae&l=92

C:\h\w\A1EE08BD\w\AD8D09A3\e>"C:\h\w\A1EE08BD\p\dotnet.exe" exec --runtimeconfig System.Net.Http.Functional.Tests.runtimeconfig.json --depsfile System.Net.Http.Functional.Tests.deps.json xunit.console.dll System.Net.Http.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Net.Http.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Http.Functional.Tests (found 1046 of 1535 test cases)
  Starting:    System.Net.Http.Functional.Tests (parallel test collections = on, max threads = 2)
    System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandler_Authentication_Test.Credentials_ServerUsesWindowsAuthentication_Success [SKIP]
      Condition(s) not met: "IsWindowsServerAvailable"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientEKUTest.HttpClient_ClientEKUServerAuth_Fails [SKIP]
      Condition(s) not met: "CanTestCertificates"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientEKUTest.HttpClient_NoEKUServerAuth_Ok [SKIP]
      Condition(s) not met: "CanTestCertificates"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientEKUTest.HttpClient_NoEKUClientAuth_Ok [SKIP]
      Condition(s) not met: "CanTestCertificates"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientEKUTest.HttpClient_ServerEKUClientAuth_Fails [SKIP]
      Condition(s) not met: "CanTestCertificates"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClient_SelectedSites_Test.RetrieveSite_Succeeds [SKIP]
      Condition(s) not met: "IsSelectedSitesTestEnabled"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClient_SelectedSites_Test.RetrieveSite_Debug_Helper [SKIP]
      Condition(s) not met: "IsSelectedSitesTestEnabled"
    System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandler_Authentication_Test.Proxy_DomainJoinedProxyServerUsesKerberos_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Authentication_Test.Credentials_DomainJoinedServerUsesKerberos_UseIpAddressAndHostHeader_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Authentication_Test.Proxy_DomainJoinedProxyServerUsesKerberos_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Authentication_Test.Credentials_ServerUsesWindowsAuthentication_Success [SKIP]
      Condition(s) not met: "IsWindowsServerAvailable"
    System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandler_Authentication_Test.Credentials_DomainJoinedServerUsesKerberos_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
    System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_Authentication_Test.Credentials_DomainJoinedServerUsesKerberos_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
    System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandler_Authentication_Test.Credentials_DomainJoinedServerUsesKerberos_UseIpAddressAndHostHeader_Success [SKIP]
      Condition(s) not met: "IsDomainJoinedServerAvailable"
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:02:13
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:04:13
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:06:13
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:08:14
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:10:14
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:12:14
   System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.Http1CloseResponseStreamConformanceTests.ReadWriteAsync_Canceled_ThrowsOperationCanceledException', Elapsed: 00:14:14

Didn't fail in the previous run and shouldn't be related to the change.

@lewing lewing merged commit 667e71d into dotnet:master Nov 5, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@kjpou1 kjpou1 Awaiting requested review from kjpou1

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@EgorBo EgorBo Awaiting requested review from EgorBo

@lambdageek lambdageek Awaiting requested review from lambdageek

@marek-safar marek-safar Awaiting requested review from marek-safar

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@vargaz vargaz Awaiting requested review from vargaz

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Interop-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lewing @steveisok