Update IpcStreamFactory state machine to handle being started on a thread that ends#43711
Merged
josalem merged 2 commits intodotnet:masterfrom Nov 5, 2020
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon |
sdmaclea
reviewed
Nov 3, 2020
Contributor
sdmaclea
left a comment
There was a problem hiding this comment.
LGTM, but I don't completely understand the code.
sywhang
approved these changes
Nov 3, 2020
Contributor
sywhang
left a comment
There was a problem hiding this comment.
LGTM modulo few things 👍
Contributor
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/346557926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39176
The first call to
IpcStream::DiagnosticsIpc::Listenhappens on the thread whereEEStartupHelperexecutes. On Windows, if that thread ends, e.g., in a custom hosting scenario, it causes all Overlapped IO that started on that thread to be cancelled. This specifically includes the asynchronous call toConnectNamedPipeinIpcStreamFactorystate machine. This causesGetNextAvailableStreamto go into an error state that would continually check the status of the aborted IO without attempting to reset itself. It always seeERROR_OPERATION_ABORTEDand doesn't self-correct. This patch accounts for mid-state change IO cancellations by automatically resetting the Listen port on the error.I reproduced the behavior from #39176 locally (12% CPU being consumed by the error state) and confirmed that this change fixed the issue (CPU is reported as 0% in the repro).
This patch also updates the write/read error code to only call
GetOverlappedResultson infinite timeouts if the error fromReadFile/WriteFilewasERROR_IO_PENDING.CC @tommcdon @lateralusX