Skip to content

[release/5.0] build-commons.sh: check for OpenSSL 1.1 on macOS (#43037)#43043

Merged
ViktorHofer merged 1 commit intodotnet:release/5.0from
akoeplinger:backport-openssl-to-5.0
Oct 6, 2020
Merged

[release/5.0] build-commons.sh: check for OpenSSL 1.1 on macOS (#43037)#43043
ViktorHofer merged 1 commit intodotnet:release/5.0from
akoeplinger:backport-openssl-to-5.0

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Oct 5, 2020

We're installing openssl@1.1 from Homebrew so we should check that version.
It looks like CI Macs don't set the /usr/local/opt/openssl symlink anymore:

Please install openssl before running this script, see https://github.com/dotnet/runtime/blob/master/docs/workflow/requirements/macos-requirements.md

Backport of #43037 to release/5.0

/cc @ViktorHofer

…t#43037)

We're installing openssl@1.1 from Homebrew so we should check that version.
It looks like CI Macs don't set the /usr/local/opt/openssl symlink anymore.

Backport of dotnet#43037 to release/5.0
@ghost
Copy link

ghost commented Oct 5, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member

cc @Anipik @mmitche, this fixes failing release/5.0 builds.

@ViktorHofer
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHofer
Copy link
Member

Merging as builds were successful and to unblock 5.0 CI.

@ViktorHofer ViktorHofer merged commit 25ef70b into dotnet:release/5.0 Oct 6, 2020
@akoeplinger akoeplinger deleted the backport-openssl-to-5.0 branch October 6, 2020 14:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants