Skip to content

Fix additional warnings introduced after fixing inconsistencty #42750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
buyaa-n merged 1 commit into from
Sep 26, 2020
Merged

Fix additional warnings introduced after fixing inconsistencty #42750

buyaa-n merged 1 commit into from
Sep 26, 2020

Conversation

@buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Sep 25, 2020

After fixing the platform inconsistency issue dotnet/roslyn-analyzers#4168 a few CA1416 warnings introduced which were hidden before because of the inconsistency issue dotnet/roslyn-analyzers#4168
New warnings found in runtime:

D:\dotnet\runtime\src\libraries\System.Net.Sockets\src\System\Net\Sockets\IOControlKeepAlive.Windows.cs(77,66): error CA1416: 'IOControlCode.KeepAliveValues' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Net.Sockets\src\System.Net.Sockets.csproj]
D:\dotnet\runtime\src\libraries\System.Net.Sockets\src\System\Net\Sockets\TCPListener.cs(266,16): error CA1416: 'Socket.SetIPProtectionLevel(IPProtectionLevel)' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Net.Sockets\src\System.Net.Sockets.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\PkcsPalWindows.cs(174,21): error CA1416: 'CspParameters.Flags.get' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\PkcsPalWindows.cs(180,39): error CA1416: 'DSACryptoServiceProvider' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\PkcsPalWindows.cs(169,31): error CA1416: 'CspParameters.Flags.get' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\PkcsPalWindows.cs(170,17): error CA1416: 'CspParameters.KeyNumber' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\PkcsPalWindows.cs(178,39): error CA1416: 'RSACryptoServiceProvider' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\HelpersWindows.cs(419,17): error CA1416: 'CspParameters.ProviderName' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\HelpersWindows.cs(415,20): error CA1416: 'CspParameters' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\HelpersWindows.cs(417,17): error CA1416: 'CspParameters.Flags.set' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]
D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\Internal\Cryptography\Pal\Windows\HelpersWindows.cs(418,17): error CA1416: 'CspParameters.KeyContainerName' is supported on 'windows' [D:\dotnet\runtime\src\libraries\System.Security.Cryptography.Pkcs\src\System.Security.Cryptography.Pkcs.csproj]

@buyaa-n buyaa-n added this to the 6.0.0 milestone Sep 25, 2020
@buyaa-n buyaa-n merged commit f8e7272 into dotnet:master Sep 26, 2020
@buyaa-n buyaa-n deleted the fix_warnings_ca1416 branch September 26, 2020 00:42
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@bartonjs bartonjs bartonjs approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@buyaa-n @jeffhandley @bartonjs