Get builds working when paths contain whitespaces and utf8 chars#42671
Merged
mangod9 merged 6 commits intodotnet:masterfrom Sep 28, 2020
Merged
Get builds working when paths contain whitespaces and utf8 chars#42671mangod9 merged 6 commits intodotnet:masterfrom
mangod9 merged 6 commits intodotnet:masterfrom
Conversation
Currently builds clr+libs Validated only of windows mono is still failing.
mangod9
commented
Sep 24, 2020
| <_IlasmSwitches Condition="'$(DebugType)' == 'PdbOnly'">$(_IlasmSwitches) -DEBUG=OPT</_IlasmSwitches> | ||
| <_IlasmSwitches Condition="'$(Optimize)' == 'True'">$(_IlasmSwitches) -OPTIMIZE</_IlasmSwitches> | ||
| <_IlasmSwitches Condition="'$(IlasmResourceFile)' != ''">$(_IlasmSwitches) -RESOURCES=$(IlasmResourceFile)</_IlasmSwitches> | ||
| <_IlasmSwitches Condition="'$(IlasmResourceFile)' != ''">$(_IlasmSwitches) -RESOURCES="$(IlasmResourceFile)"</_IlasmSwitches> |
Member
Author
There was a problem hiding this comment.
this change will need to propagate to SDK for builds to actually work.
mangod9
commented
Sep 24, 2020
| <IncludePath>$([MSBuild]::NormalizeDirectory('$(IntermediateOutputPath)', 'version'))</IncludePath> | ||
| <IlasmFlags>$(IlasmFlags) -INCLUDE=$(IncludePath)</IlasmFlags> | ||
| <IncludePathTrimmed>$(IncludePath.TrimEnd('\'))</IncludePathTrimmed> | ||
| <IlasmFlags>$(IlasmFlags) -INCLUDE="$(IncludePathTrimmed)"</IlasmFlags> |
Member
Author
There was a problem hiding this comment.
this is required since for some reason ilasm doesnt like a trailing \ if the include path is quoted
trylek
approved these changes
Sep 27, 2020
Member
trylek
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for making these improvements!
This was referenced Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially Fixes #42397
Currently builds clr+libs
Validated only of windows
mono build still needs work