Add NetworkError.TimedOut, rename Unknown to Other#40841
Add NetworkError.TimedOut, rename Unknown to Other#40841antonfirsov merged 5 commits intodotnet:masterfrom
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl |
|
@antonfirsov The failure in System.Net.Requests.Tests looks related, though I'm not sure how your change would affect this... can you take a look? |
|
That also could have been caused by the recent ConnectionFactory PR. |
|
The problem is in missing mapping in https://github.com/dotnet/runtime/blob/master/src/libraries/System.Net.Requests/src/System/Net/WebException.cs#L74 @antonfirsov if you're afk, I can try to fix it. I think this might be fixed by #40880. Since we have |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NetworkError.TimedOutUnknowntoOtherassuming my proposal gets accepted, will revert if notWill add a case for
TimedOutas soon as the Connection PR gets merged. (Based on local test it gets translated fine.)