add macOS 11 with arm64 to RID graph#40644
Merged
Anipik merged 1 commit intodotnet:masterfrom Aug 12, 2020
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
Member
Anipik
reviewed
Aug 11, 2020
| <Versions>10.10;10.11;10.12;10.13;10.14;10.15</Versions> | ||
| </RuntimeGroup> | ||
|
|
||
| <RuntimeGroup Include="osx"> |
Contributor
There was a problem hiding this comment.
Is there a specific reason behind creating a new Item ? cant we just add it to the existing osx item ?
Member
Author
There was a problem hiding this comment.
11 shall run on arm64 as well. existing versions are x64 only. I followed some other examples.
Anipik
approved these changes
Aug 11, 2020
Contributor
Anipik
left a comment
There was a problem hiding this comment.
LGTM, other than 1 comment.
safern
approved these changes
Aug 12, 2020
This was referenced Aug 18, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added new node to fork for upcomming arm64.
I assume 3.1 and 2.1 will have same graph even if we probably will not make arm builds.
fixes #40479