Port -- WASM: enable System.Runtime.Tests to Preview8 #39478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WASM: fix System.Runtime.Tests * Enable System.Runtime.Tests * Disable test and don't strip link attributes on all product assemblies * PR feedback
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
danmoseley
approved these changes
Jul 16, 2020
Member
|
feel free to merge when green |
Member
Author
|
Sure. I think this will need: #39487 |
Anipik
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting: 423e164 to get System.Runtime.Tests coverage on Preview8 for WASM in case any fixes are needed to be backported to get coverage.
cc: @danmosemsft @steveisok @akoeplinger @Anipik @aik-jahoda