Struct, arg and float reg cleanup#39284
Merged
CarolEidt merged 1 commit intodotnet:masterfrom Jul 15, 2020
Merged
Conversation
- Unify the handling of promoted args when assigning offsets; there's no need to handle independent vs. dependent promotion separately. - Use `varTypeUsesFloatReg` where appropriate. - Some minor refactoring of initial reg assignment. These changes are preparatory to improved struct promotion for args. - Add a 'Clear' method to `StructPromotionHelper` for use after inlining (not yet in use, as it produces diffs). - Wrap a SIMD field node in `GT_OBJ` only if needed. -
Contributor
Author
|
@dotnet/jit-contrib PTAL |
sandreenko
approved these changes
Jul 14, 2020
| // UpdateLifeFieldVar: Update live sets for only the given field of a multi-reg LclVar node. | ||
| // | ||
| // Arguments: | ||
| // lclNode - the GT_LCL_VAR node. |
Contributor
There was a problem hiding this comment.
Nit: it looks like the header was not updated for this function.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that; rather than fix in this PR, I've fixed it in the follow-up PR #39326 which I'll rebase on this once this one's merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero diff changes preparatory to improving struct promotion for args
varTypeUsesFloatRegwhere appropriate.StructPromotionHelperfor use after inlining (not yet in use, as it produces diffs).GT_OBJonly if needed.