[wasm] Addressing System.Runtime.InteropServices.RuntimeInformation.Tests failures #39073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
a04a242 to
d5fa5af
Compare
99 tasks
akoeplinger
reviewed
Jul 10, 2020
src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices.RuntimeInformation/tests/RuntimeIdentifierTests.cs
Outdated
Show resolved
Hide resolved
d5fa5af to
48dd09e
Compare
akoeplinger
approved these changes
Jul 10, 2020
Member
akoeplinger
left a comment
There was a problem hiding this comment.
Looks good but please also reenable the project in tests.proj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #38422
This PR looks to address test failures in
System.Runtime.InteropServices.RuntimeInformationwhen running on Browser wasm.Tests run: 7, Errors: 0, Failures: 0, Skipped: 3. Time: 0.048805sRuntimeInformation.RuntimeIdentifiercurrently returnsunknownon Browser, and it is typically set by the hosting app.typeof(object).Assembly.Locationcurrently returns""on Browser, also probably set by the hosting app.