[Arm64] ASIMD ReverseElement8 ReverseElement16 ReverseElement32#38850
Merged
echesakov merged 9 commits intodotnet:masterfrom Jul 7, 2020
Merged
Conversation
…nsiccodegenarm64.cpp
|
Tagging subscribers to this area: @tannergooding |
Contributor
Author
CarolEidt
approved these changes
Jul 7, 2020
| break; | ||
|
|
||
| case NI_AdvSimd_ReverseElement16: | ||
| GetEmitter()->emitIns_R_R(ins, emitSize, targetReg, op1Reg, |
Contributor
There was a problem hiding this comment.
This seems like it could be table-driven, but I suspect that it just isn't worth it, given that there are so few of these?
Contributor
Author
There was a problem hiding this comment.
I thought about generalizing this, so it could be table-driven, but, as you said, - there is little benefit of doing so - since there are only three intrinsics like these.
tannergooding
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #37014