Skip to content

[wasm] Enable System.Threading.Channels.Tests #38849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdh1418 merged 2 commits into from
Jul 10, 2020
Merged

[wasm] Enable System.Threading.Channels.Tests #38849

mdh1418 merged 2 commits into from
Jul 10, 2020

Conversation

@mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 7, 2020 •
edited
Loading

Contributes to #38422
Tests run: 1096, Errors: 0, Failures: 0, Skipped: 32. Time: 3.3619789s

The tests failing that are now skipped by the second commit were either Cannot wait on events on this runtime. or Cannot wait on monitors on this runtime.

@mdh1418 mdh1418 requested review from akoeplinger and steveisok July 7, 2020 04:15
@ghost
Copy link

ghost commented Jul 7, 2020

Tagging subscribers to this area: @tarekgh
Notify danmosemsft if you want to be subscribed.

@mdh1418 mdh1418 force-pushed the mdhwang/properly_skip_system_threading_channels_tests branch from 3af42a7 to 1863d31 Compare July 7, 2020 13:18
stephentoub
stephentoub reviewed Jul 7, 2020
View reviewed changes
@mdh1418 mdh1418 force-pushed the mdhwang/properly_skip_system_threading_channels_tests branch from 1863d31 to 9936555 Compare July 7, 2020 15:44
@mdh1418
Copy link
Member Author

mdh1418 commented Jul 10, 2020

In Azure DevOps, Build iOS x64 Release AllSubsets_Mono, CoreCLR Product Build Linux arm release, and CoreCLR Product Build Linux arm64 release are all green.

@mdh1418 mdh1418 merged commit ba60d75 into dotnet:master Jul 10, 2020
@mdh1418 mdh1418 deleted the mdhwang/properly_skip_system_threading_channels_tests branch July 10, 2020 12:41
@steveisok steveisok mentioned this pull request Jul 10, 2020
Closed
99 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@stephentoub stephentoub stephentoub approved these changes

@steveisok steveisok Awaiting requested review from steveisok

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-System.Threading.Channels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdh1418 @akoeplinger @stephentoub