Skip to content

Add tizen-arm64 RIDs#38832

Merged
ericstj merged 2 commits intodotnet:masterfrom
WonyoungChoi:add-tizen-rids
Jul 8, 2020
Merged

Add tizen-arm64 RIDs#38832
ericstj merged 2 commits intodotnet:masterfrom
WonyoungChoi:add-tizen-rids

Conversation

@WonyoungChoi
Copy link
Contributor

Since tizen 6.0.0, arm64 will be supported.

Since tizen 6.0.0, arm64 will be supported
@WonyoungChoi
Copy link
Contributor Author

/cc @swift-kim @HJLeee

@ghost
Copy link

ghost commented Jul 7, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member

safern commented Jul 7, 2020

cc: @ericstj -- since tizen5.5.0 doesn't define arm64 RID, is the best to just suppress the errors?

@ericstj
Copy link
Member

ericstj commented Jul 7, 2020

I believe you can fix the error by only listing the version in a single runtimegroup, as was done with rhel.

So instead of

    <RuntimeGroup Include="tizen">
      <Parent>linux</Parent>
      <Architectures>x86;armel</Architectures>
      <Versions>4.0.0;5.0.0;5.5.0;6.0.0</Versions>
    </RuntimeGroup>
    <RuntimeGroup Include="tizen">
      <Parent>linux</Parent>
      <Architectures>arm64</Architectures>
      <Versions>6.0.0</Versions>
    </RuntimeGroup>

Do

    <RuntimeGroup Include="tizen">
      <Parent>linux</Parent>
      <Architectures>x86;armel</Architectures>
      <Versions>4.0.0;5.0.0;5.5.0</Versions>
    </RuntimeGroup>
    <RuntimeGroup Include="tizen">
      <Parent>linux</Parent>
      <Architectures>x86;armel;arm64</Architectures>
      <Versions>6.0.0</Versions>
    </RuntimeGroup>

@WonyoungChoi
Copy link
Contributor Author

@ericstj If version 6.0.0 is separated, the version will not be able to include the lower versions. So I just added arm64 to all tizen versions. I don't want to limit some possibilities.

@ericstj
Copy link
Member

ericstj commented Jul 8, 2020

I see. It looks like this is the same way we handled it with win. This is probably the best way for now. If you want to create a better way to deal with this you could make a change here https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateRuntimeGraph.cs.

@WonyoungChoi
Copy link
Contributor Author

@ericstj Thanks for the advice. As of now, I want to open the possibility of arm64 support in lower tizen versions.

@ericstj ericstj merged commit 26045bc into dotnet:master Jul 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants