JIT: allow inlinees with delegate invoke#38479
Merged
jkotas merged 1 commit intodotnet:masterfrom Jun 27, 2020
Merged
Conversation
RyuJit would not inline methods that contained delegate invokes. Remove this limitation. Closes dotnet#10048. See also dotnet#37941.
Member
Author
|
@erozenfeld PTAL cc @dotnet/jit-contrib jit-diffs shows small size increase, most prominently from methods in the command line parser that are marked with aggressive inlining. |
Member
|
Where is the CommandLine assembly coming from? It sounds broken to use AggressiveInlining extensively in command line parsers. |
jkotas
approved these changes
Jun 27, 2020
BruceForstall
approved these changes
Jun 27, 2020
Contributor
It's whatever is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RyuJit would not inline methods that contained delegate invokes. Remove
this limitation.
Closes #10048. See also #37941.