[wasm] Disable threading tests in System.IO#38380
Conversation
This allows the test suite to finish on WASM: `Tests run: 891, Errors: 0, Failures: 8, Skipped: 30. Time: 60.276597s`
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Changes look good to me. What were the 8 failing tests? Skips were added to failing tests in System.Threading.Timer/tests for helix to work, but do we not need to do the same for other suites now? There were several failures from #38355 that only appeared after disabling other failing tests in src/libraries/System.Threading.Tasks/tests/Task/TaskFromAsyncTest2.cs and src/libraries/System.Threading.Tasks/tests/Task/TaskWaitAllAnyTest.cs.
|
@mdh1418 the failures were all due to Those tests are using NamedPipeServerStream which opens a Socket. We can indeed disable these. |
| } | ||
|
|
||
| [Fact] | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] |
There was a problem hiding this comment.
What were the failures here?
There was a problem hiding this comment.
WASM-ERR: Unhandled Exception:
WASM-ERR: System.Threading.SynchronizationLockException: Cannot wait on events on this runtime.
WASM-ERR: at System.Threading.WaitHandle.WaitOneCore(IntPtr waitHandle, Int32 millisecondsTimeout)
WASM-ERR: at System.Threading.WaitHandle.WaitOneNoCheck(Int32 millisecondsTimeout)
WASM-ERR: at System.Threading.WaitHandle.WaitOne()
WASM-ERR: at Microsoft.DotNet.XHarness.TestRunners.Xunit.ThreadlessXunitTestRunner.Run(String assemblyFileName, Boolean printXml, XunitFilters filters)
WASM-ERR: at Microsoft.DotNet.XHarness.TestRunners.Xunit.WasmApplicationEntryPoint.Run()
WASM-ERR: at SimpleWasmTestRunner.Main(String[] args)
There was a problem hiding this comment.
Does that mean every async test (ones that complete asynchronously) is going to need to be disabled? Or am I misunderstanding what this stack represents?
There was a problem hiding this comment.
It definitely seems that way. Unless you know of any creative ideas to get a message pump in w/o significantly modifying the tests?
There was a problem hiding this comment.
Yes that's my current understanding. We're looking at ways how to fix that.
This allows the test suite to finish on WASM:
Tests run: 883, Errors: 0, Failures: 0, Skipped: 30. Time: 58.57082s