Extend redundant zero init optimization to recognize assignments to `GT_OBJ(lcl_addr)` by erozenfeld · Pull Request #38314 · dotnet/runtime

erozenfeld · 2020-06-24T01:19:26Z

No diffs in frameworks and benchmarks. Diffs are expected once we start using Roslyn that includes @benadams's change dotnet/roslyn#45262

erozenfeld · 2020-06-24T01:23:46Z

Diff for the example from #38070:

; Assembly listing for method DoubleZero:SingleMethod():System.Threading.Tasks.ValueTask`1[ReadResult]:this
; Emitting BLENDED_CODE for X64 CPU with AVX - Windows
; optimized code
; rsp based frame
; partially interruptible
; Final local variable assignments
;
;* V00 this         [V00    ] (  0,  0   )     ref  ->  zero-ref    this class-hnd
;  V01 RetBuf       [V01,T00] (  4,  4   )   byref  ->  rsi        
-; V02 loc0         [V02    ] (  4,  4   )  struct (48) [rsp+0x20]   do-not-enreg[XSFB] must-init addr-exposed ld-addr-op
+; V02 loc0         [V02    ] (  3,  3   )  struct (48) [rsp+0x20]   do-not-enreg[XSFB] must-init addr-exposed ld-addr-op
;  V03 OutArgs      [V03    ] (  1,  1   )  lclBlk (32) [rsp+0x00]   "OutgoingArgSpace"
;* V04 tmp1         [V04    ] (  0,  0   )  struct (40) zero-ref    do-not-enreg[SB] ld-addr-op "Inline ldloca(s) first use temp"
;
; Lcl frame size = 80

G_M9604_IG01:
       push     rsi
       sub      rsp, 80
-      vzeroupper 
       vxorps   xmm4, xmm4
       vmovdqa  xmmword ptr [rsp+20H], xmm4
       vmovdqa  xmmword ptr [rsp+30H], xmm4
       vmovdqa  xmmword ptr [rsp+40H], xmm4
       mov      rsi, rdx
-					        ;; bbWeight=1    PerfScore 5.83
+						;; bbWeight=1    PerfScore 4.83
G_M9604_IG02:
-      xor      ecx, ecx
-      vxorps   xmm0, xmm0
-      vmovdqu  xmmword ptr [rsp+28H], xmm0
-      vmovdqu  xmmword ptr [rsp+38H], xmm0
-      mov      qword ptr [rsp+48H], rcx
       mov      dword ptr [rsp+20H], -1
       lea      rcx, [rsp+20H]
       call     System.Runtime.CompilerServices.AsyncMethodBuilderCore:Start(byref)
       lea      rcx, bword ptr [rsp+28H]
       mov      rdx, rsi
       call     System.Runtime.CompilerServices.AsyncValueTaskMethodBuilder`1[ReadResult][DoubleZero+ReadResult]:get_Task():System.Threading.Tasks.ValueTask`1[ReadResult]:this
       mov      rax, rsi
-    					        ;; bbWeight=1    PerfScore 8.08
+						;; bbWeight=1    PerfScore 4.50
G_M9604_IG03:
       add      rsp, 80
       pop      rsi
       ret      
						;; bbWeight=1    PerfScore 1.75

-; Total bytes of code 96, prolog size 30, PerfScore 25.97, (MethodHash=85efda7b) for method DoubleZero:SingleMethod():System.Threading.Tasks.ValueTask`1[ReadResult]:this
+; Total bytes of code 70, prolog size 27, PerfScore 18.48, (MethodHash=85efda7b) for method DoubleZero:SingleMethod():System.Threading.Tasks.ValueTask`1[ReadResult]:this
; ============================================================

erozenfeld · 2020-06-24T01:24:26Z

@AndyAyersMS PTAL /cc @dotnet/jit-contrib

AndyAyersMS · 2020-06-24T01:55:45Z

Could also be that PMI is not instantiating enough interesting value classes to show broad applicability here -- you might experiment with adding a value class with a GC ref field to the "types to try" array.

AndyAyersMS

LGTM. Left a couple of suggestions.

AndyAyersMS · 2020-06-24T01:57:33Z

src/coreclr/src/jit/optimizer.cpp

Should we check for GT_BLK too?

Good suggestion, thanks.

…GT_OBJ(lcl_addr)` and `GT_BLK(lcl_addr)` Fixes dotnet#38070.

erozenfeld · 2020-06-24T04:13:51Z

There are a few diffs after adding GT_BLK cases.

x64 framework pmi:

PMI CodeSize Diffs for System.Private.CoreLib.dll, framework assemblies for  default jit
Summary of Code Size diffs:
(Lower is better)
Total bytes of diff: -170 (-0.00% of base)
    diff is an improvement.
Top file improvements (bytes):
        -121 : System.Private.CoreLib.dasm (-0.00% of base)
         -49 : System.IO.Compression.dasm (-0.06% of base)
2 total files with Code Size differences (2 improved, 0 regressed), 262 unchanged.
Top method improvements (bytes):
         -49 (-5.51% of base) : System.IO.Compression.dasm - Zip64ExtraField:GetAndRemoveZip64Block(List`1,bool,bool,bool,bool):Zip64ExtraField
         -13 (-8.44% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,byref):bool
         -13 (-9.56% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int,byref):bool
         -13 (-9.56% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParseExactMultiple(ReadOnlySpan`1,ref,IFormatProvider,int,byref):bool
         -12 (-9.76% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParse(ReadOnlySpan`1,byref):bool
         -12 (-9.76% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParseExact(ReadOnlySpan`1,ref,IFormatProvider,byref):bool
         -12 (-9.60% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParse(ReadOnlySpan`1,IFormatProvider,byref):bool
          -8 (-7.41% of base) : System.Private.CoreLib.dasm - TimeSpan:Parse(ReadOnlySpan`1,IFormatProvider):TimeSpan
          -8 (-5.19% of base) : System.Private.CoreLib.dasm - TimeSpan:ParseExact(ReadOnlySpan`1,ref,IFormatProvider,int):TimeSpan
          -8 (-7.92% of base) : System.Private.CoreLib.dasm - TimeSpanParse:ParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int):TimeSpan
          -8 (-7.92% of base) : System.Private.CoreLib.dasm - TimeSpanParse:ParseExactMultiple(ReadOnlySpan`1,ref,IFormatProvider,int):TimeSpan
          -7 (-3.93% of base) : System.Private.CoreLib.dasm - TimeSpan:ParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int):TimeSpan
          -7 (-6.80% of base) : System.Private.CoreLib.dasm - TimeSpanParse:Parse(ReadOnlySpan`1,IFormatProvider):TimeSpan
Top method improvements (percentages):
         -12 (-9.76% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParse(ReadOnlySpan`1,byref):bool
         -12 (-9.76% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParseExact(ReadOnlySpan`1,ref,IFormatProvider,byref):bool
         -12 (-9.60% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParse(ReadOnlySpan`1,IFormatProvider,byref):bool
         -13 (-9.56% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int,byref):bool
         -13 (-9.56% of base) : System.Private.CoreLib.dasm - TimeSpanParse:TryParseExactMultiple(ReadOnlySpan`1,ref,IFormatProvider,int,byref):bool
         -13 (-8.44% of base) : System.Private.CoreLib.dasm - TimeSpan:TryParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,byref):bool
          -8 (-7.92% of base) : System.Private.CoreLib.dasm - TimeSpanParse:ParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int):TimeSpan
          -8 (-7.92% of base) : System.Private.CoreLib.dasm - TimeSpanParse:ParseExactMultiple(ReadOnlySpan`1,ref,IFormatProvider,int):TimeSpan
          -8 (-7.41% of base) : System.Private.CoreLib.dasm - TimeSpan:Parse(ReadOnlySpan`1,IFormatProvider):TimeSpan
          -7 (-6.80% of base) : System.Private.CoreLib.dasm - TimeSpanParse:Parse(ReadOnlySpan`1,IFormatProvider):TimeSpan
         -49 (-5.51% of base) : System.IO.Compression.dasm - Zip64ExtraField:GetAndRemoveZip64Block(List`1,bool,bool,bool,bool):Zip64ExtraField
          -8 (-5.19% of base) : System.Private.CoreLib.dasm - TimeSpan:ParseExact(ReadOnlySpan`1,ref,IFormatProvider,int):TimeSpan
          -7 (-3.93% of base) : System.Private.CoreLib.dasm - TimeSpan:ParseExact(ReadOnlySpan`1,ReadOnlySpan`1,IFormatProvider,int):TimeSpan
13 total methods with Code Size differences (13 improved, 0 regressed), 243284 unchanged.

erozenfeld · 2020-06-24T04:36:43Z

One of the framework diffs:

; Assembly listing for method TimeSpanParse:TryParse(ReadOnlySpan`1,IFormatProvider,byref):bool

G_M4265_IG01:
       push     rsi
       sub      rsp, 80
       vzeroupper 
       vxorps   xmm4, xmm4
       vmovdqa  xmmword ptr [rsp+30H], xmm4
       vmovdqa  xmmword ptr [rsp+40H], xmm4
       mov      rsi, r8
						;; bbWeight=1    PerfScore 4.83
G_M4265_IG02:
       mov      r9, bword ptr [rcx]
       mov      r8d, dword ptr [rcx+8]
-      xor      eax, eax
-      mov      qword ptr [rsp+30H], rax
-      mov      byte  ptr [rsp+38H], 0
       lea      rax, bword ptr [rsp+40H]
       mov      bword ptr [rax], r9
       mov      dword ptr [rax+8], r8d
G_M4265_IG03:
       vmovdqu  xmm0, xmmword ptr [rcx]
       vmovdqu  xmmword ptr [rsp+20H], xmm0
G_M4265_IG04:
       lea      rcx, bword ptr [rsp+20H]
       lea      r9, [rsp+30H]
       mov      r8, rdx
       mov      edx, 3
       call     TimeSpanParse:TryParseTimeSpan(ReadOnlySpan`1,ubyte,IFormatProvider,byref):bool
       test     eax, eax
       je       SHORT G_M4265_IG07
G_M4265_IG05:
       mov      rax, qword ptr [rsp+30H]
       mov      qword ptr [rsi], rax
       mov      eax, 1
G_M4265_IG06:
       add      rsp, 80
       pop      rsi
       ret      
G_M4265_IG07:
       xor      eax, eax
       mov      qword ptr [rsi], rax
G_M4265_IG08:
       add      rsp, 80
       pop      rsi
       ret      

-; Total bytes of code 125, prolog size 24, PerfScore 36.83, (MethodHash=8014ef56) for method TimeSpanParse:TryParse(ReadOnlySpan`1,IFormatProvider,byref):bool
+; Total bytes of code 113, prolog size 24, PerfScore 33.38, (MethodHash=8014ef56) for method TimeSpanParse:TryParse(ReadOnlySpan`1,IFormatProvider,byref):bool

DrewScoggins · 2020-06-24T21:40:52Z

Not sure why that leg timed out, but all of the jobs completed correctly. So you can go ahead and merge despite that failure.

benaadams · 2020-06-24T22:27:11Z

Thank you! 😍

Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 24, 2020

erozenfeld assigned AndyAyersMS Jun 24, 2020

AndyAyersMS approved these changes Jun 24, 2020

View reviewed changes

Extend redundant zero init optimization to recognize assignments to `…

9d35b6d

…GT_OBJ(lcl_addr)` and `GT_BLK(lcl_addr)` Fixes dotnet#38070.

erozenfeld force-pushed the DoubleZero38070 branch from 6ca7b19 to 9d35b6d Compare June 24, 2020 04:10

erozenfeld assigned erozenfeld and unassigned AndyAyersMS Jun 24, 2020

erozenfeld merged commit 1ebe3b5 into dotnet:master Jun 24, 2020

benaadams mentioned this pull request Jun 24, 2020

Call AsyncXMethodBuilder.Create prior to storing fields to elide double zeroing dotnet/roslyn#45262

Merged

CarolEidt mentioned this pull request Oct 15, 2020

Extra zeroing with structs and inlining #8186

Closed

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend redundant zero init optimization to recognize assignments to `GT_OBJ(lcl_addr)`#38314

Extend redundant zero init optimization to recognize assignments to `GT_OBJ(lcl_addr)`#38314
erozenfeld merged 1 commit intodotnet:masterfrom
erozenfeld:DoubleZero38070

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

AndyAyersMS commented Jun 24, 2020

Uh oh!

AndyAyersMS left a comment

Uh oh!

AndyAyersMS Jun 24, 2020

Uh oh!

erozenfeld Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

DrewScoggins commented Jun 24, 2020

Uh oh!

benaadams commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

AndyAyersMS commented Jun 24, 2020

Uh oh!

AndyAyersMS left a comment

Choose a reason for hiding this comment

Uh oh!

AndyAyersMS Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

erozenfeld Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

erozenfeld commented Jun 24, 2020

Uh oh!

DrewScoggins commented Jun 24, 2020

Uh oh!

benaadams commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants