Propagate basic block flags after a failed inline.#38243
Merged
erozenfeld merged 1 commit intodotnet:masterfrom Jun 23, 2020
Merged
Propagate basic block flags after a failed inline.#38243erozenfeld merged 1 commit intodotnet:masterfrom
erozenfeld merged 1 commit intodotnet:masterfrom
Conversation
This is a fllow-up to dotnet#37335 and dotnet#37840. When an inline fails we replace `GT_RET_EXPR`with the original `GT_CALL` node. `GT_RET_EXPR`may end up in a basic block other than the original `GT_CALL` so we need to propagate basic block flags. Fixes dotnet#36588.
Member
Author
|
No diffs in x64 PMI frameworks. @AndyAyersMS PTAL /cc @dotnet/jit-contrib |
Contributor
|
The only remaining So, should we create individual issues for each of the failures, or should we treat them all as probable cases of #37117 and related tailcallstress issues? I'm inclined to disable the tailcallstress mode entirely -- on the libraries stress modes at least -- until it is known to be error free. |
Member
Author
|
Since we had a major tail call change in this release I think we should try to get tailcallstress clean before shipping .NET 5. I'm ok with disabling tailcallstress mode on the libraries stress modes and opening a .NET 5 item to get it re-enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fllow-up to #37335 and #37840.
When an inline fails we replace
GT_RET_EXPRwith theoriginal
GT_CALLnode.GT_RET_EXPRmay end up ina basic block other than the original
GT_CALLso we needto propagate basic block flags.
Fixes #36588.