Move the Buffer.Memmove<T> implementation into the runtime specific files since it requires a runtime specific BulkMoveWithWriteBarrier icall.#37920
Merged
vargaz merged 1 commit intodotnet:masterfrom Jun 16, 2020
Conversation
…iles since it requires a runtime specific BulkMoveWithWriteBarrier icall. The mono version has an extra type argument since it uses copy functions which are type specific. Also add an elementCount > 0 check to avoid icall overhead if possible.
Collaborator
|
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
stephentoub
approved these changes
Jun 15, 2020
lambdageek
reviewed
Jun 15, 2020
| ves_icall_System_Buffer_BulkMoveWithWriteBarrier (guint8 *destination, guint8 *source, size_t len, MonoType *type) | ||
| { | ||
| mono_gc_wbarrier_range_copy (destination, source, byte_count); | ||
| if (MONO_TYPE_IS_REFERENCE (type)) |
Member
There was a problem hiding this comment.
Is this ever going to be true if
if (!RuntimeHelpers.IsReferenceOrContainsReferences<T>())
is false?
Contributor
Author
There was a problem hiding this comment.
Not right now, but more callers could be added in the future.
alexischr
approved these changes
Jun 16, 2020
Contributor
Author
|
The runtime failures look unrelated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mono version has an extra type argument since it uses copy functions which are type specific.
Also add an elementCount > 0 check to avoid icall overhead if possible.