Allow X509Certificates to be trimmed in HttpClientHandler.#37909
Merged
eerhardt merged 2 commits intodotnet:masterfrom Jun 16, 2020
Merged
Allow X509Certificates to be trimmed in HttpClientHandler.#37909eerhardt merged 2 commits intodotnet:masterfrom
eerhardt merged 2 commits intodotnet:masterfrom
Conversation
When DangerousAcceptAnyServerCertificateValidator is never used, the backing static field won't be trimmed by the ILLinker. This will keep empty X509Certificate2 and X509Chain types around, which is the only thing in the X509Certificates assembly. See dotnet/linker#1270
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Jun 15, 2020
src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DangerousAcceptAnyServerCertificateValidator is never used, the backing static field won't be trimmed by the ILLinker. This will keep empty X509Certificate2 and X509Chain types around, which is the only thing in the X509Certificates assembly.
See dotnet/linker#1270