Add System.Runtime.CompilerServices.ModuleInitializerAttribute#37625
Merged
stephentoub merged 8 commits intodotnet:masterfrom Jun 11, 2020
Merged
Add System.Runtime.CompilerServices.ModuleInitializerAttribute#37625stephentoub merged 8 commits intodotnet:masterfrom
stephentoub merged 8 commits intodotnet:masterfrom
Conversation
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
stephentoub
reviewed
Jun 9, 2020
...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/ModuleInitializerAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 9, 2020
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
stephentoub
approved these changes
Jun 9, 2020
...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/ModuleInitializerAttribute.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@stephentoub @jkotas I believe I have addressed feedback here. |
jkotas
reviewed
Jun 11, 2020
...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/ModuleInitializerAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jun 11, 2020
...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/ModuleInitializerAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Jun 11, 2020
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Jun 11, 2020
...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/ModuleInitializerAttribute.cs
Outdated
Show resolved
Hide resolved
…erServices/ModuleInitializerAttribute.cs
stephentoub
approved these changes
Jun 11, 2020
Member
Author
|
@stephentoub @jkotas is this ready to squash merge? |
Member
|
Yes, once the CI is green. |
Member
Author
|
Thanks for your help with this! @stephentoub @jkotas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #35749
Sorry about the delay on this, it slipped under the radar for a bit.