Fix nullable annotation of AsnEncodedData.RawData#37572
Closed
stephentoub wants to merge 1 commit intodotnet:masterfrom
Closed
Fix nullable annotation of AsnEncodedData.RawData#37572stephentoub wants to merge 1 commit intodotnet:masterfrom
stephentoub wants to merge 1 commit intodotnet:masterfrom
Conversation
Member
|
Yeah, OK, back to my original position of "let's call it non-nullable". So I guess we'll introduce a behavioral change from NetFX regarding the few places that are checking for null, but if it's just things like |
Member
Author
|
Replaced by #37598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bartonjs, this fixes the nullable annotation of AsnEncodedData.RawData to be nullable.
Are you sure you want to go this route, rather than making it so that RawData never returns null? This is correct based on the current implementation, but the fallout is non-trivial, and it definitely seems to be penalizing the common case.