Skip to content

Expose Encoding.Latin1 #37550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkotas merged 1 commit into from
Jun 7, 2020
Merged

Expose Encoding.Latin1 #37550

jkotas merged 1 commit into from
Jun 7, 2020

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jun 6, 2020

@Dotnet-GitSync-Bot
Copy link
Collaborator

Dotnet-GitSync-Bot commented Jun 6, 2020

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jkotas
Copy link
Member

jkotas commented Jun 7, 2020

The test failure is #37132

@jkotas jkotas merged commit e8964cc into dotnet:master Jun 7, 2020
@stephentoub stephentoub deleted the latin1 branch October 12, 2020 00:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

No one assigned

Labels

area-System.Runtime new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API proposal: expose System.Text.Encoding.Latin1 getter publicly

4 participants

@stephentoub @Dotnet-GitSync-Bot @jkotas @GrabYourPitchforks