Add non-generic TaskCompletionSource#37452
Merged
stephentoub merged 1 commit intodotnet:masterfrom Jun 5, 2020
Merged
Conversation
|
Tagging subscribers to this area: @tarekgh |
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
scalablecory
approved these changes
Jun 4, 2020
Contributor
scalablecory
left a comment
There was a problem hiding this comment.
Satisfying change :).
tarekgh
reviewed
Jun 4, 2020
src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/TaskCompletionSource.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Jun 4, 2020
- Adds the type, almost an exact copy of `TaskCompletionSource<TResult>`, but creating a `Task` instead of a `Task<TResult>`. Primary benefits here are symmetry, smaller `Task` object, and not forcing a developer to specify an unnecessary type name. - Adds tests for both TCS and TCS<TResult>. - Switches a bunch of usage of the generic type over to the non-generic, both in src and tests.
fc33590 to
12656c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskCompletionSource<TResult>, but creating aTaskinstead of aTask<TResult>. Primary benefits here are symmetry, smallerTaskobject, and not forcing a developer to specify an unnecessary type name.TCSandTCS<TResult>.Fixes #17393