Return nullptr from impSimdAsHWIntrinsic if the baseline ISA has been marked as disabled#37272
Merged
tannergooding merged 1 commit intodotnet:masterfrom Jun 2, 2020
Merged
Conversation
… marked as disabled
Member
Author
|
CC. @CarolEidt, @BruceForstall, @echesakovMSFT |
Member
Author
|
The remaining failures are slightly different.
Working on fixing these, if there hasn't been sign-off yet I'll add them to this PR otherwise I will get up a new PR. |
Contributor
The way this is tested is a bit of a hack, and there may be a better way to test that an intrinsic has been recognized, but it's not immediately obvious what that would be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #37260