Add ICU App-Local support on Mono#37037
Merged
safern merged 2 commits intodotnet:masterfrom May 27, 2020
Merged
Conversation
vargaz
reviewed
May 27, 2020
| { | ||
| private static bool GetInvariantSwitchValue() => | ||
| GetSwitchValue("DOTNET_SYSTEM_GLOBALIZATION_INVARIANT"); | ||
|
|
Contributor
There was a problem hiding this comment.
The linker will need a bool method which it can transform to false to disable ICU support at app build time.
Member
There was a problem hiding this comment.
Does the existing GlobalizationMode.get_Invariant property work for this? (It would need to be tranformed to true.)
Member
Author
There was a problem hiding this comment.
FWIW, we're still doing something similar:
Member
Author
There was a problem hiding this comment.
@vargaz does this look good, or is there any action I should take?
Member
Author
There was a problem hiding this comment.
I merged this, but if something else need to happen here, I'm happy to put up a follow up PR.
jkotas
reviewed
May 27, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 27, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.CoreCLR.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
May 27, 2020
tarekgh
reviewed
May 27, 2020
CoffeeFlux
approved these changes
May 27, 2020
Contributor
CoffeeFlux
left a comment
There was a problem hiding this comment.
Runtime changes look good to me, thanks!
Member
Author
tarekgh
approved these changes
May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds AppLocalIcu switch support on Mono. I also refactored GlobalizationMode to share the sources in between Mono and CoreCLR to avoid duplicating all the AppLocal and UseNls switches logic.
cc: @jkotas @thaystg @akoeplinger @tarekgh @ericstj