Add EventPipe array types to the profiler APIs#37035
Merged
davmason merged 4 commits intodotnet:masterfrom Jun 5, 2020
Merged
Conversation
|
Tagging subscribers to this area: @tommcdon |
noahfalk
approved these changes
Jun 5, 2020
Member
noahfalk
left a comment
There was a problem hiding this comment.
LGTM (with a few commented suspicious things in the tests)
src/coreclr/tests/src/profiler/native/eventpipeprofiler/eventpipeprofiler.cpp
Outdated
Show resolved
Hide resolved
d919cd3 to
eeabecb
Compare
eeabecb to
3c44317
Compare
Contributor
Author
In case it wasn't obvious I was testing outside of the repo so I could use the latest TraceEvent and validate that it correctly parsed my array type metadata generation. Then I reworked a bunch of things and forgot to update the test in the tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #36242. Allow profilers to emit array types as well.