Skip to content

Update the -vs switch and add docs for it#37026

Merged
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:VsSwitchLocalSDK
May 27, 2020
Merged

Update the -vs switch and add docs for it#37026
ViktorHofer merged 3 commits intodotnet:masterfrom
ViktorHofer:VsSwitchLocalSDK

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented May 26, 2020

We don't need to point to the testhost folder anymore (for libraries) to support VS Test Explorer.

@ViktorHofer
Remove testhost DOTNET_ROOT from vs switch
6d51051 
We don't need to point to the testhost folder anymore for libraries for
supporting VS Test Explorer.
@ViktorHofer
Update docs
5e06650
@ViktorHofer ViktorHofer requested a review from tannergooding May 26, 2020 20:24
@ghost
Copy link

ghost commented May 26, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jaredpar jaredpar mentioned this pull request May 26, 2020
Closed
@AntonLapounov
Copy link
Member

AntonLapounov commented May 27, 2020

Could you please also fix this line? The short form -v does not work, because PowerShell binds it to the $vs parameter instead of $properties.

runtime/eng/build.ps1

Line 29 in 08e0445

Write-Host " -verbosity MSBuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] (short: -v)"

AntonLapounov
AntonLapounov reviewed May 27, 2020
View reviewed changes
AntonLapounov
AntonLapounov reviewed May 27, 2020
View reviewed changes
@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 27, 2020

Could you please also fix this line? The short form -v does not work, because PowerShell binds it to the $vs parameter instead of $properties.

Thanks, I decided to instead fix the -v alias.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented May 27, 2020

Unrelated failure:

Failed to download package 'System.Collections.Immutable.1.7.1' from 'https(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) 1408F119:SSL routines:SSL3_GET_RECORD:decryption failed or bad record mac

@ViktorHofer ViktorHofer merged commit 511cada into dotnet:master May 27, 2020
@ViktorHofer ViktorHofer deleted the VsSwitchLocalSDK branch May 27, 2020 13:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AntonLapounov AntonLapounov AntonLapounov approved these changes

@tannergooding tannergooding Awaiting requested review from tannergooding

Assignees

No one assigned

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorHofer @AntonLapounov @Dotnet-GitSync-Bot