BundleProbeTest: Enable disabled tests#36327
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
|
Tagging subscribers to this area: @swaroop-sridhar |
A few of the bundle probe tests were failing on Linux-musl-x64-release. This change adjusts the test to circumvent the failure. Fixes dotnet#35755
| // Therefore the type on this test is adjusted to circumvent the failure. | ||
| [UnmanagedFunctionPointer(CallingConvention.StdCall)] | ||
| public delegate bool BundleProbeDelegate([MarshalAs(UnmanagedType.LPWStr)] string path, IntPtr size, IntPtr offset); | ||
| public delegate byte BundleProbeDelegate([MarshalAs(UnmanagedType.LPWStr)] string path, IntPtr size, IntPtr offset); |
There was a problem hiding this comment.
Is this ok to be LPWstr or should become IntPtr?
If the goal is to inline or avoid a stub, can that happen if the call needs to pin the string?
There was a problem hiding this comment.
Yes the LPWstr is OK.
I spoke with @jkoritzinsky about this today, looks like the problem was wrt managed bool vs native bool values in the return type. Please see: #36372.
|
Will existing scenarios use this code path? (without singlefilehost). |
@VSadov In the non-single-file case, we simply check that the |
A few of the bundle probe tests were failing on Linux-musl-x64-release.
This change adjusts the test to circumvent the failure.
Fixes #35755