[wasm][debugger] Add support for deref'ing pointers#36260
Merged
radical merged 1 commit intodotnet:masterfrom Jul 7, 2020
Merged
[wasm][debugger] Add support for deref'ing pointers#36260radical merged 1 commit intodotnet:masterfrom
radical merged 1 commit intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: @thaystg |
vargaz
reviewed
May 12, 2020
Contributor
There was a problem hiding this comment.
Note that might crash the app. It might be better to do this in js (access the ArrayBuffer object which represents the memory of the wasm instance).
0c9b2ef to
79546bc
Compare
a7047ac to
15017a8
Compare
15017a8 to
d9f1958
Compare
fcecc56 to
6441acb
Compare
6441acb to
946c255
Compare
radical
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of mono/mono#19760, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!