Preempt Watson exception handling#36179
Merged
mangod9 merged 4 commits intodotnet:masterfrom May 11, 2020
Merged
Conversation
Closed
mangod9
commented
May 10, 2020
mangod9
commented
May 10, 2020
| NOTHROW; | ||
| GC_NOTRIGGER; | ||
| MODE_ANY; | ||
| GC_TRIGGERS; |
Member
Author
There was a problem hiding this comment.
Is GC_TRIGGERS appropriate here although GCX_PREEMP() is no longer invoked here?
Member
There was a problem hiding this comment.
There doesn't seem to be anything in this method that could trigger a GC.
mangod9
commented
May 10, 2020
jkotas
reviewed
May 10, 2020
jkotas
approved these changes
May 10, 2020
Maoni0
approved these changes
May 10, 2020
Member
|
thanks for fixing this! |
jkotas
reviewed
May 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #35866. Switching to GC pre-emptive mode in CLR20r3BucketParamsManager::PopulateBucketParameters