Skip to content

Revert "Build an apphost with hostfxr and hostpolicy linked in (#35368)"#36076

Merged
safern merged 1 commit intodotnet:masterfrom
safern:RevertMuslBreak
May 8, 2020
Merged

Revert "Build an apphost with hostfxr and hostpolicy linked in (#35368)"#36076
safern merged 1 commit intodotnet:masterfrom
safern:RevertMuslBreak

Conversation

@safern
Copy link
Member

@safern safern commented May 8, 2020

This reverts commit f6e5219.

This change broke Linux_musl_x64 Release rolling builds. We need to bring pass rate up and has been failing for 2 days without any fix. Usually we try to revert after 1 day.

Fixes: #35967

cc: @dotnet/runtime-infrastructure @VSadov @swaroop-sridhar

@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar
Notify danmosemsft if you want to be subscribed.

@safern safern force-pushed the RevertMuslBreak branch from 21cd4f3 to 6cc01d4 Compare May 8, 2020 00:28
swaroop-sridhar
swaroop-sridhar reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@swaroop-sridhar swaroop-sridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be OK with this -- in order to keep the lab green.

However, @VSadov @safern it'd be good to actually verify that the release tests will pass if we revert this change. I'll start a run now -- unless one of you already checked it. Thanks.

@swaroop-sridhar
Copy link
Contributor

swaroop-sridhar commented May 8, 2020

CC: @jeffschwMSFT

@swaroop-sridhar
Copy link
Contributor

swaroop-sridhar commented May 8, 2020

For more details please see: #35755

@safern
Copy link
Member Author

safern commented May 8, 2020

I queued a rolling build from this branch here: https://dev.azure.com/dnceng/public/_build/results?buildId=635948&view=results

@VSadov
Copy link
Member

VSadov commented May 8, 2020

is it possible to run the musli thing on this PR with some azp command?

@VSadov
Copy link
Member

VSadov commented May 8, 2020

@safern - Thanks!

@safern
Copy link
Member Author

safern commented May 8, 2020

is it possible to run the musli thing on this PR with some azp command?

No, you have to queue it manually from the UI and then set the branch to: refs/pull/<pr-id>/merge

@safern
Copy link
Member Author

safern commented May 8, 2020

So the Installer leg in Linux_musl_x64 Release is green in my rolling build with this revert:
https://dev.azure.com/dnceng/public/_build/results?buildId=635948&view=logs&j=bf685d4e-b902-5b69-856e-ae456c52090c

@safern safern mentioned this pull request May 8, 2020
Merged
@safern safern merged commit 3011955 into dotnet:master May 8, 2020
@safern safern deleted the RevertMuslBreak branch May 8, 2020 03:19
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@swaroop-sridhar swaroop-sridhar swaroop-sridhar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Host

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installer Build and Test coreclr Linux_musl_x64 Release failing in CI

4 participants

@safern @swaroop-sridhar @VSadov @Dotnet-GitSync-Bot